fix: getAccount #10402
Merged
fix: getAccount #10402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
mattsse,
Rjected,
emhane and
gakonst
as code owners
mattsse
requested changes
Aug 20, 2024
| let nonce = account.nonce; | ||
| let code_hash = account.bytecode_hash.unwrap_or(KECCAK_EMPTY); | ||
| let account = state.basic_account(address).map_err(Self::Error::from_eth_err)?; | ||
| if let Some(account) = account { |
There was a problem hiding this comment.
styl nit:
let use let Some() else {return Ok(None)} here to get rid of the scope
|
|
||
| let account = eth_api.get_account(address, Default::default()).await.unwrap(); | ||
| let expected_account = | ||
| alloy_consensus::Account { code_hash: KECCAK_EMPTY, ..Default::default() }; |
There was a problem hiding this comment.
I believe this is available from the reth-rpc-types crate so we don't need the alloy-consensus dep here
There was a problem hiding this comment.
this test case can also be added as an additional call here
reth/crates/rpc/rpc-builder/tests/it/http.rs
Line 177 in 72ed7a9
emhane
approved these changes
Aug 20, 2024
greged93
force-pushed
the
fix/getAccount
branch
from
d0b7007
to
7ca7e78
Compare
mattsse
approved these changes
Aug 21, 2024
mattsse
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking out the implementation of the endpoint by Geth and Nethermind, I believe we should be returning an
Nonevalue if the account if not found in the state.Example:
Returns
null.