perf(trie): remove some clones #10406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
Rjected,
rakita,
joshieDo,
shekhirin,
fgimenez and
mattsse
as code owners
|
nice, will review in am |
mattsse
approved these changes
Aug 21, 2024
mattsse
added
the
C-perf
rkrasiuk
reviewed
Aug 21, 2024
| fn extend_inner(&mut self, other: Cow<'_, Self>) { | ||
| self.accounts.extend(other.accounts.iter().map(|(&k, &v)| (k, v))); | ||
|
|
||
| self.storages.reserve(other.storages.len()); |
There was a problem hiding this comment.
Don't see the point in that if there's gonna be multiple calls to extend
DaniPopes
force-pushed
the
dani/trie-clones
branch
from
7a9f2a7
to
326b253
Compare
rkrasiuk
reviewed
Aug 26, 2024
rkrasiuk
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since extending hashmaps is always a linear operation, we can reduce cloning to only when necessary on a per-field/element basis.
Duplicate some
extendfns to take refs to be more efficient thanextend(other.clone()).These show up in profiles under
EngineApiTreeHandler->MemoryOverlayStateProvider::new.