Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpc): config network specific transaction type in node builder #10417

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 21, 2024

Ref #8780.

@emhane emhane added A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library labels Aug 21, 2024
@emhane emhane added the A-op-reth Related to Optimism and op-reth label Aug 21, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks for extracting this.

this was easy to follow now and gets us a significant step closer to what we're looking for

crates/e2e-test-utils/src/transaction.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/core.rs Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/helpers/types.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/helpers/transaction.rs Outdated Show resolved Hide resolved
@emhane emhane enabled auto-merge August 22, 2024 14:13
@emhane emhane added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 7d8196e Aug 22, 2024
35 checks passed
@emhane emhane deleted the emhane/ethapi-networktypes branch August 22, 2024 14:48
@paradigmxyz paradigmxyz deleted a comment from harunfox72s Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants