Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: block_range #10418

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: block_range #10418

merged 1 commit into from
Aug 21, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Aug 21, 2024 •
edited
Loading

Fixes a bug in block_range implementation for BlockchainProvider2. The current implementation was using database_blocks in order to get the length of the block retrieved from database.

However, because database_blocks was passed to blocks.append, this caused its length to always be 0 (see Rust documentation).

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-db Related to the database A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 21, 2024
shekhirin
shekhirin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, thank you!

@shekhirin shekhirin added this pull request to the merge queue Aug 21, 2024
Merged via the queue into paradigmxyz:main with commit ae8ce20 Aug 21, 2024
35 checks passed
@greged93 greged93 mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greged93 @shekhirin