Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ReceiptProviderIdExt #10420

Merged
merged 2 commits into from
Aug 21, 2024
Merged

test: ReceiptProviderIdExt #10420

merged 2 commits into from
Aug 21, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Aug 21, 2024 •
edited
Loading

Adds tests for the ReceiptProviderIdExt and closes #10341.

@shekhirin
Copy link
Collaborator

Please use special keywords for automatically closing the issue when referencing it https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 21, 2024
shekhirin
shekhirin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shekhirin shekhirin added this pull request to the merge queue Aug 21, 2024
Merged via the queue into paradigmxyz:main with commit f0197a5 Aug 21, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test ReceiptProviderIdExt implementation of BlockchainProvider2<DB>
2 participants
@greged93 @shekhirin