Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc/otterscan): set fullblock.tx_count with block's #10421

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 21, 2024

Otterscan use fullblock.transactionCount to indicate the paginate, so we should set this field always to the full block's one, instead of the drained block.

ref https://github.com/erigontech/erigon/blob/a0049fe9687e79f33e2b191a933aca8a90bda42a/turbo/jsonrpc/otterscan_api.go#L490

… txcount

Signed-off-by: jsvisa <delweng@gmail.com>
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mattsse mattsse added the A-rpc Related to the RPC implementation label Aug 21, 2024
@mattsse mattsse enabled auto-merge August 21, 2024 14:23
@mattsse mattsse added this pull request to the merge queue Aug 21, 2024
Merged via the queue into paradigmxyz:main with commit 5a522c8 Aug 21, 2024
35 checks passed
@jsvisa jsvisa deleted the ots-block-tx-count branch August 21, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants