Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: exact gasUsed for eth_createAccessList #10422

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

malik672
Copy link
Contributor

@malik672 malik672 commented Aug 21, 2024

closes issue #10416

@malik672 malik672 changed the title Scout Feat: exact gasUsed for eth_createAccessList Aug 21, 2024
@emhane emhane added A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain C-bug An unexpected or incorrect behavior and removed C-debt Refactor of code section that is hard to understand or maintain labels Aug 21, 2024
@@ -259,31 +259,24 @@ pub trait EthCall: Call + LoadPendingBlock {
let precompiles = get_precompiles(env.handler_cfg.spec_id);
let mut inspector = AccessListInspector::new(initial, from, to, precompiles);

let (result, env) = self.inspect(&mut db, env, &mut inspector)?;
let (_, mut env) = self.inspect(&mut db, env, &mut inspector)?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this now ignores the result of the initial call, I'd like to keep that and only apply the transact after the match.

I'm fine with having another match result for the transact call

@malik672 malik672 requested a review from mattsse August 22, 2024 11:34
@mattsse mattsse enabled auto-merge August 26, 2024 10:37
@mattsse mattsse added this pull request to the merge queue Aug 26, 2024
Merged via the queue into paradigmxyz:main with commit 1b1e835 Aug 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants