Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trie): filter out removed nodes on extend #10433

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Filter out removed in-memory nodes on extend. This led to stale cached nodes being picked up during state root calculation for long chain of in-memory blocks.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Aug 22, 2024
@rkrasiuk rkrasiuk requested a review from Rjected as a code owner August 22, 2024 05:07
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit f425521 Aug 22, 2024
35 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/fix-trie-filter-out-deleted-nodes-on-extend branch August 22, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants