Make js-feature non default

[nkysg]

towards #10441

[mattsse]

this likely needs to also be enabled for eth-rpc-types

[mattsse]

let's make js-tracer default here, for this pr, and solve making it non-default in this crate in a followup pr

[mattsse]

wait, why does this even compile

this should not compile if the feature is not enabled

reth/crates/rpc/rpc/src/debug.rs

Lines 404 to 405 in bb734e9

	let mut inspector =
	JsInspector::new(code, config).map_err(Eth::Error::from_eth_err)?;

[nkysg]

I think maybe this place make compile.

[nkysg]

remove this feature then debug.rs can't compile。 The errors

error[E0422]: cannot find struct, variant or union type `TransactionContext` in this scope
   --> crates/rpc/rpc/src/debug.rs:121:30
    |
121 |                         Some(TransactionContext {
    |                              ^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `TransactionRequest`
    |
   ::: /Users/ysg/.cargo/registry/src/index.crates.io-6f17d22bba15001f/alloy-rpc-types-eth-0.2.1/src/transaction/request.rs:17:1
    |
17  | pub struct TransactionRequest {
    | ----------------------------- similarly named struct `TransactionRequest` defined here

error[E0422]: cannot find struct, variant or union type `TransactionContext` in this scope
   --> crates/rpc/rpc/src/debug.rs:269:26
    |
269 |                     Some(TransactionContext {
    |                          ^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `TransactionRequest`

Do we need to touch revm-inspectors? @mattsse

[mattsse]

okay, since dealing with features is a bit weird, I want to merge it like this and transition to non default js-trace crate

[mattsse]

@nkysg next step would be

feature gating all the jstracer usage, e.g. if js-tracer feature is missing this should return an unsupported error:

reth/crates/rpc/rpc/src/debug.rs

Line 391 in a942467

GethDebugTracerType::JsTracer(code) => {

[nkysg]

Got it