chore(tree): remove BlockAttachment usage #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
requested review from
rkrasiuk,
mattsse,
fgimenez and
rakita
as code owners
Rjected
force-pushed
the
dan/revise-attachment
branch
from
50fe24a
to
b338737
Compare
rkrasiuk
approved these changes
Aug 22, 2024
| /// If we don't know the block's parent, we return `Disconnected`, as we can't claim that the block | ||
| /// is valid or not. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| pub enum BlockStatusTwo { |
There was a problem hiding this comment.
smol nit: can we make this a number so that we are consistent w/ BlockchainProvider2 and it's clear that it should be renamed in the fut
Rjected
force-pushed
the
dan/revise-attachment
branch
from
b338737
to
8a407c2
Compare
Rjected
force-pushed
the
dan/revise-attachment
branch
from
8a407c2
to
986d1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new types,
BlockStatusTwoandInsertPayloadOkTwo, which removes theBlockAttachmentfromBlockStatusTwo::Valid. This is now not necessary due to the new engine design.