Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exex): instrument ExEx::launch with the span #10481

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(exex): instrument ExEx::launch with the span #10481

merged 1 commit into from
Aug 23, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools A-exex Execution Extensions labels Aug 23, 2024
rkrasiuk
rkrasiuk approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, lgtm

@shekhirin shekhirin added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 961821c Aug 23, 2024
35 checks passed
@shekhirin shekhirin deleted the alexey/exex-launch-span branch August 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk