Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Add method removal functionality for RPC transports #10497

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

SkandaBhat
Copy link
Contributor

Fixes #9798

This PR introduces new methods to remove RPC methods from specific
transports (HTTP, WebSocket, IPC) or from all transports simultaneously:

  • remove_http_method: Removes a method from the HTTP transport
  • remove_ws_method: Removes a method from the WebSocket transport
  • remove_ipc_method: Removes a method from the IPC transport
  • remove_method_from_all_transports: Removes a method from all configured transports

Unit tests have been added to verify the correct functionality of these new methods.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, naming and doc nit

crates/rpc/rpc-builder/src/lib.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-builder/src/lib.rs Show resolved Hide resolved
@mattsse
Copy link
Collaborator

mattsse commented Aug 24, 2024

needs fmt

@mattsse
Copy link
Collaborator

mattsse commented Aug 24, 2024

btw if you're looking for something else ptal #10494 :)

@mattsse mattsse enabled auto-merge August 24, 2024 08:24
@mattsse mattsse added this pull request to the merge queue Aug 24, 2024
Merged via the queue into paradigmxyz:main with commit 082f37c Aug 24, 2024
34 checks passed
@SkandaBhat SkandaBhat deleted the override-rpc branch August 24, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support replacing rpc handlers
2 participants