Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(op): Add OpChainSpec #10516

Merged
merged 17 commits into from
Aug 27, 2024
Merged

chore(op): Add OpChainSpec #10516

merged 17 commits into from
Aug 27, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 25, 2024 •
edited
Loading

Closes #10512

Adds type OpChainSpec and plugs into static OP stack chain specs.

@emhane emhane added the A-op-reth Related to Optimism and op-reth label Aug 25, 2024
@emhane emhane requested a review from klkvr August 25, 2024 18:07
klkvr
klkvr approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/cli/cli/src/chainspec.rs Show resolved Hide resolved
mattsse
mattsse reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one q, re uncommented feature

crates/optimism/chainspec/src/lib.rs Outdated Show resolved Hide resolved
Base automatically changed from emhane/op-specs to main August 26, 2024 18:13
@emhane emhane requested a review from joshieDo as a code owner August 26, 2024 18:13
mattsse
mattsse reviewed Aug 26, 2024
View reviewed changes
crates/node/core/Cargo.toml Outdated Show resolved Hide resolved
crates/optimism/chainspec/src/lib.rs Outdated Show resolved Hide resolved
@emhane emhane enabled auto-merge August 27, 2024 12:13
@emhane emhane added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 7df7bc2 Aug 27, 2024
36 checks passed
@emhane emhane deleted the emhane/op-chainspec branch August 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@klkvr klkvr klkvr approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emhane @mattsse @klkvr