Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: add if_not_else clippy lint #10524

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

tcoratger
Copy link
Contributor

@mattsse let me know what you think about this one:

Negations reduce the readability of statements.

@mattsse mattsse added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 26, 2024
@mattsse
Copy link
Collaborator

mattsse commented Aug 26, 2024

smol conflict

@tcoratger
Copy link
Contributor Author

smol conflict

@mattsse fixed

@mattsse mattsse added this pull request to the merge queue Aug 26, 2024
@shekhirin
Copy link
Collaborator

Just so I know, are you doing these fixes automatically via clippy fix? Some of these changes are a bit invasive and touch untrivial logic (like https://github.com/paradigmxyz/reth/pull/10524/files#diff-102c8ff04a628fe92ccef5f8d0ac6eef702ad248c7a2b8e59e65cf12bb05287f), but if it's done automatically, then it's okay with me 🙂

@tcoratger
Copy link
Contributor Author

Just so I know, are you doing these fixes automatically via clippy fix? Some of these changes are a bit invasive and touch untrivial logic (like https://github.com/paradigmxyz/reth/pull/10524/files#diff-102c8ff04a628fe92ccef5f8d0ac6eef702ad248c7a2b8e59e65cf12bb05287f), but if it's done automatically, then it's okay with me 🙂

Yeah most of them via clippy fix and the other ones via the terminal suggestion, copy and paste when clippy fix doesn't work

Merged via the queue into paradigmxyz:main with commit 709e7b7 Aug 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants