Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tree): make remove_before bound inclusive #10559

Merged
merged 1 commit into from
Aug 27, 2024
Merged

chore(tree): make remove_before bound inclusive #10559

merged 1 commit into from
Aug 27, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 26, 2024

This never uses the Unbounded variant, so let's specify that this is an inclusive bound.

@Rjected Rjected added C-enhancement New feature or request A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 26, 2024
@Rjected Rjected force-pushed the dan/make-remove-before-inclusive-bound branch from 16f7de9 to 6eef27d Compare August 26, 2024 22:37
mattsse
mattsse approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer Bound here because this makes it obvious and I only have to look at the function call.

but I don't mind changing this

@Rjected
Copy link
Member Author

Rjected commented Aug 27, 2024

I prefer Bound here because this makes it obvious and I only have to look at the function call.

hmm yeah, actually let me see if I can accomplish the rewrite of remove_before without removing the bound

@Rjected Rjected force-pushed the dan/make-remove-before-inclusive-bound branch from 6eef27d to 67edc9d Compare August 27, 2024 19:02
@Rjected
Copy link
Member Author

Rjected commented Aug 27, 2024

nvm, not sure that it's possible

@Rjected Rjected enabled auto-merge August 27, 2024 19:12
@Rjected Rjected added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit b1d6e27 Aug 27, 2024
34 checks passed
@Rjected Rjected deleted the dan/make-remove-before-inclusive-bound branch August 27, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse