feat(exex): subscribe to notifications explicitly #10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
c4d7798
to
eae2985
Compare
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
379ca8f
to
467456b
Compare
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
467456b
to
aff910e
Compare
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
6e69df2
to
342b15f
Compare
mattsse
reviewed
Aug 30, 2024
shekhirin
commented
Sep 2, 2024
shekhirin
commented
Sep 2, 2024
…tifications-subscribe
mattsse
reviewed
Sep 3, 2024
crates/exex/exex/src/manager.rs
Outdated
|
|
||
| /// Subscribe to notifications. | ||
| pub fn subscribe(&mut self) -> ExExNotifications<'_> { | ||
| ExExNotifications::Left(ExExNotificationsWithoutHead(&mut self.notifications)) |
There was a problem hiding this comment.
why are we wrapping this here?
There was a problem hiding this comment.
mpsc::Receiver doesn't implement Stream by default. https://docs.rs/tokio-stream/0.1.15/tokio_stream/wrappers/struct.ReceiverStream.html exists for this, but I didn't want to import a new dep just for that
There was a problem hiding this comment.
using either here is a bit weird, I'd prefer a custom type over this
mattsse
reviewed
Sep 3, 2024
mattsse
reviewed
Sep 4, 2024
crates/exex/exex/src/manager.rs
Outdated
|
|
||
| /// Subscribe to notifications. | ||
| pub fn subscribe(&mut self) -> ExExNotifications<'_> { | ||
| ExExNotifications::Left(ExExNotificationsWithoutHead(&mut self.notifications)) |
There was a problem hiding this comment.
using either here is a bit weird, I'd prefer a custom type over this
no, I don't think so. Components are the same for all ExExes, so we should just pass them to the |
why does it need that? |
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
942b1da
to
5d0385a
Compare
This reverts commit e3ddac4.
…tifications-subscribe
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
ed5c1a8
to
e6d1d4c
Compare
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
e6d1d4c
to
d357e2d
Compare
mattsse
added
S-breaking
shekhirin
added
the
S-blocked
shekhirin
force-pushed
the
alexey/exexcontext-notifications-subscribe
branch
from
c25d0dc
to
291929c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #10571. Implements a new way to subscribe to notifications.
This is not a breaking change, so it will not require any changes to existing ExExes, but the use of
ExExNotifications::recv()is discouraged nowreth/crates/exex/exex/src/manager.rs
Lines 176 to 179 in d357e2d
Later, when we add an ability to subscribe with the given head, it will not be a breaking change too and users will just need to do
ctx.notifications.with_head(head)instead of usingctx.notificationsdirectly.The functionality of
ExExNotificationsWithHeaddoes not include the backfill logic yet.