chore(txpool): implement ensure_max_init_code_size() #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1062 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 313 313
Lines 34108 34140 +32
=======================================
+ Hits 25551 25576 +25
- Misses 8557 8564 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
onbjerg
added
C-enhancement
mattsse
requested changes
Jan 27, 2023
Comment on lines
+60
to
+64
| fn ensure_max_init_code_size( | ||
| &self, | ||
| transaction: Self::Transaction, | ||
| max_init_code_size: usize, | ||
| ) -> Result<(), PoolError> { |
There was a problem hiding this comment.
this seems ok for now, we'll figure out the right ergonomics later
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
mattsse
approved these changes
Jan 27, 2023
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 5, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 5, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 6, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #924
I'm not much sure whether it could close #924. I'll be really appreciate to point out me if I misunderstood the issue.