perf(tree): streaming state root from proofs #10902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-perf
rkrasiuk
force-pushed
the
rkrasiuk/perf-streaming-state-root-from-proofs
branch
from
42de71c
to
896890b
Compare
rkrasiuk
force-pushed
the
rkrasiuk/perf-streaming-state-root-from-proofs
branch
from
6ae9a96
to
3cddf8a
Compare
Rjected
reviewed
Sep 16, 2024
Comment on lines
+43
to
+44
| /// Histogram of state root duration | ||
| pub(crate) state_root_from_proofs_histogram: Histogram, |
There was a problem hiding this comment.
should also add a _duration: Gauge here
rkrasiuk
force-pushed
the
rkrasiuk/perf-streaming-state-root-from-proofs
branch
from
42064af
to
02f41f5
Compare
|
superseded by #11154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBD