feat: move next block cfg and env to configureevm #10962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
Rjected,
fgimenez,
emhane,
onbjerg,
rakita and
gakonst
as code owners
github-actions
bot
added
A-block-building
mattsse
added
A-execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10950
this moves next block cfg handling to configureevm trait.
because the parent header is not enough to configure the block env, this requires a helper type that contains attributes that the CL provides.
for OP, I think we could extract the impl of fn next_cfg_and_block_env so it becomes reusable for other configure evm impls (alphabet) but defer to @onbjerg here