Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trie): use global thread pool in async state root calculation #11057

Merged
merged 6 commits into from
Sep 23, 2024
Merged

feat(trie): use global thread pool in async state root calculation #11057

merged 6 commits into from
Sep 23, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Sep 19, 2024 •
edited
Loading

Uses rayon's global thread pool in the async state root calculation.

@fgimenez fgimenez force-pushed the fgimenez/async-root-use-global-thread-pool branch from 00c03a9 to 405fa58 Compare September 19, 2024 20:10
emhane
emhane reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on thread model defo seems like right way forward. a node will need to be ran off this pr for a week or smthg though, to make sure it doesn't mess smthg up that we don't see right away, since we don't have a diagram anywhere of the current thread model of the node - unless you made one? pls share some screen shots of the metric panels after those days in this pr, comparing with public node.

@fgimenez fgimenez force-pushed the fgimenez/async-root-use-global-thread-pool branch from 405fa58 to e330dbd Compare September 20, 2024 08:58
@fgimenez
Copy link
Member Author

a node will need to be ran off this pr for a week or smthg though, to make sure it doesn't mess smthg up that we don't see right away,

absolutely, I'm already running it on a node focusing on the reth_engine_rpc_new_payload_v3 metric for comparison, will update this PR when we have more data

since we don't have a diagram anywhere of the current thread model of the node - unless you made one?

not yet, will try to prepare something, thx @emhane !

@fgimenez fgimenez changed the title feat: use global thread pool in async state root calculation feat(trie): use global thread pool in async state root calculation Sep 20, 2024
@fgimenez fgimenez marked this pull request as ready for review September 20, 2024 09:15
@fgimenez fgimenez force-pushed the fgimenez/async-root-use-global-thread-pool branch from d38ea61 to 8032123 Compare September 20, 2024 10:57
@rkrasiuk rkrasiuk added C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Sep 20, 2024
mattsse
mattsse approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems okay

@fgimenez fgimenez added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit efa5d45 Sep 23, 2024
36 checks passed
@fgimenez fgimenez deleted the fgimenez/async-root-use-global-thread-pool branch September 23, 2024 17:59
ewoolsey pushed a commit to ewoolsey/reth that referenced this pull request Sep 25, 2024
@fgimenez @ewoolsey
feat(trie): use global thread pool in async state root calculation (p…
57563bb 
…aradigmxyz#11057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane left review comments

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgimenez @mattsse @rkrasiuk @emhane