chore(engine): replace reth_primitives with alloy_primitives #11064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishekkochar <abhishekkochar2@gmail.com>
Abhishekkochar
requested review from
rkrasiuk,
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
onbjerg
reviewed
Sep 20, 2024
crates/engine/tree/src/tree/mod.rs
Outdated
| @@ -24,8 +25,7 @@ use reth_payload_builder::PayloadBuilderHandle; | |||
| use reth_payload_primitives::{PayloadAttributes, PayloadBuilderAttributes}; | |||
| use reth_payload_validator::ExecutionPayloadValidator; | |||
| use reth_primitives::{ | |||
| Block, BlockNumHash, BlockNumber, GotExpected, Header, SealedBlock, SealedBlockWithSenders, | |||
| SealedHeader, B256, U256, | |||
| Block, BlockNumHash, GotExpected, Header, SealedBlock, SealedBlockWithSenders, SealedHeader, | |||
There was a problem hiding this comment.
BlockNumHash is in alloy-eips, would be great to replace that too
There was a problem hiding this comment.
Yes, you are correct. However, I aim to limit to only alloy_primitives given not too many changes. Let me check if there aren't not too many instance.
onbjerg
added
the
C-debt
Signed-off-by: Abhishekkochar <abhishekkochar2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10749