Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move tests in reth_execution_types::chain to reth-evm-optimism #11115

Merged
merged 10 commits into from
Oct 15, 2024
Merged

chore: move tests in reth_execution_types::chain to reth-evm-optimism #11115

merged 10 commits into from
Oct 15, 2024

Conversation

0xriazaka
Copy link
Contributor

@0xriazaka 0xriazaka commented Sep 23, 2024 •
edited by emhane
Loading

Closes #11111

onbjerg
onbjerg previously requested changes Sep 23, 2024
View reviewed changes
crates/optimism/evm/src/lib.rs Show resolved Hide resolved
@onbjerg onbjerg changed the title Copy tests in reth_execution_types::chain to reth-evm-optimism chore: move tests in reth_execution_types::chain to reth-evm-optimism Sep 23, 2024
@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test A-op-reth Related to Optimism and op-reth labels Sep 23, 2024
mattsse
mattsse requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, this is helpful, the only thing we need to do is as pointed out, also port the additional optimism receipt fields

mattsse
mattsse requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not compile yet, needs same changes, like private API on Chain

@0xriazaka
Copy link
Contributor Author

this does not compile yet, needs same changes, like private API on Chain

wdm with "same changes"

@emhane
Copy link
Member

emhane commented Oct 8, 2024

how's it going with this, need any help?

@mattsse mattsse added this pull request to the merge queue Oct 15, 2024
Merged via the queue into paradigmxyz:main with commit d4be773 Oct 15, 2024
39 checks passed
@mattsse mattsse mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy tests in reth_execution_types::chain to reth-evm-optimism
4 participants
@0xriazaka @emhane @onbjerg @mattsse