fix(engine): is_fork header traversal
#11368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
force-pushed
the
rkrasiuk/fix-is-fork-logic
branch
2 times, most recently
from
d1ed0a2
to
8fedc6b
Compare
mattsse
requested changes
Oct 1, 2024
Comment on lines
946
to
+934
| while let Some(current_block) = self.sealed_header_by_hash(current_hash)? { | ||
| if current_block.hash() == self.state.tree_state.canonical_block_hash() { | ||
| if current_block.hash() == canonical_head.hash { | ||
| return Ok(false) | ||
| } | ||
| // We already passed the canonical head | ||
| if current_block.number <= canonical_head.number { | ||
| break | ||
| } |
There was a problem hiding this comment.
this loop is now safe and cuts off at the canonical head which is correct because this is the section we need to check here.
Rjected
approved these changes
Oct 1, 2024
rkrasiuk
force-pushed
the
rkrasiuk/fix-is-fork-logic
branch
from
8fedc6b
to
f09fa29
Compare
rkrasiuk
added
C-bug
mattsse
reviewed
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the header does not extend the canonical chain, on
is_forkmethod invocation the engine might start traversing all of headers in the database and hit transaction timeout.