Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): Define NodePrimitives::Block #11399

Merged
merged 85 commits into from
Oct 18, 2024
Merged

chore(sdk): Define NodePrimitives::Block #11399

merged 85 commits into from
Oct 18, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 2, 2024 •
edited
Loading

Closes #11240

@emhane emhane marked this pull request as draft October 2, 2024 02:04
@emhane
Blanket impl of BlockBody for types that deref to BlockBody type
d2035c6
@emhane
Move reth_primitives::Block impl into trait methods of reth_node_api:…
505e1b6 
…:Block
@emhane
Blanket impl Block for all types that deref to Block type
899c076
@emhane
Separate Block and BlockBody traits into 2 modules
5537a71
@emhane
Make SealedHeader type def generic over header and body
d148202
@emhane
Make BlockWithSenders type def generic over block
d047fde
@emhane
Add super traits for Block
2cbcaff
@emhane
Implement Block for reth_primitives::Block
a8a696a
@emhane
Simplify Block impl for placeholder EthBlock
4576457
@emhane
Simplify Block impl for placeholder OpBlock
ab8254c
@emhane
Impl construction and destruction of Block
9fa9739
@emhane
Move reth_node_api::{Block, BlockBody} into new module reth_primitive…
f228239 
…s::traits
@emhane
Impl BlockBody for reth_primitives::BlockBody
9ab1f08
@emhane
Fix Compact impl for SealedHeader
1f64027
@emhane
Add todo for default impl of BlockBody::size
5d35204
@emhane emhane requested a review from mattsse October 7, 2024 16:38
mattsse
mattsse requested changes Oct 7, 2024
View reviewed changes
crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved
@emhane emhane requested a review from DaniPopes as a code owner October 8, 2024 12:02
@emhane emhane changed the base branch from emhane/sealed-block to main October 8, 2024 12:02
@emhane emhane requested a review from mattsse October 8, 2024 12:22
@mattsse mattsse mentioned this pull request Oct 14, 2024
Closed
mattsse
mattsse requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense,
could we extract the transaction trait impl and do that separately?
imo we can also hold off on introducing the associated block type here

crates/primitives/src/traits/block/mod.rs Outdated Show resolved Hide resolved
crates/ethereum/node/src/node.rs Show resolved Hide resolved
crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved
@emhane emhane changed the base branch from main to emhane/add-primitives-traits-mod-block October 17, 2024 12:51
Base automatically changed from emhane/add-primitives-traits-mod-block to main October 17, 2024 13:30
emhane
emhane commented Oct 17, 2024
View reviewed changes
crates/rpc/rpc/src/eth/helpers/types.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/traits.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also req by lint

@emhane emhane requested a review from mattsse October 17, 2024 14:07
Rjected
Rjected approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane enabled auto-merge October 18, 2024 09:22
@emhane emhane added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit cb60482 Oct 18, 2024
40 checks passed
@emhane emhane deleted the emhane/block-trait branch October 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@rakita rakita Awaiting requested review from rakita

@joshieDo joshieDo Awaiting requested review from joshieDo

@shekhirin shekhirin Awaiting requested review from shekhirin

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

introduce Block trait abstraction
3 participants
@emhane @Rjected @mattsse