Add eip1559 params to payload #11473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cody-wang-cb
requested review from
mattsse,
Rjected,
fgimenez,
emhane and
gakonst
as code owners
mattsse
reviewed
Oct 4, 2024
cody-wang-cb
force-pushed
the
cody/eip1559-params
branch
from
1651917
to
84a47ef
Compare
cody-wang-cb
commented
Oct 7, 2024
refcell
reviewed
Oct 7, 2024
refcell
reviewed
Oct 7, 2024
refcell
reviewed
Oct 7, 2024
|
The spec can be found here: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md |
tynes
reviewed
Oct 7, 2024
clabby
reviewed
Oct 7, 2024
Rjected
reviewed
Oct 7, 2024
Comment on lines
+251
to
+263
| impl Default for EthPayloadBuilderAttributes { | ||
| fn default() -> Self { | ||
| Self { | ||
| id: PayloadId::new([0; 8]), | ||
| parent: B256::default(), | ||
| timestamp: 0, | ||
| suggested_fee_recipient: Address::ZERO, | ||
| prev_randao: B256::default(), | ||
| withdrawals: Withdrawals::default(), | ||
| parent_beacon_block_root: None, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Requires this change in alloy I think, PTAL
alloy-rs/alloy#1442
cody-wang-cb
force-pushed
the
cody/eip1559-params
branch
from
b72cb4a
to
ea57b2a
Compare
cody-wang-cb
changed the title
clabby
reviewed
Oct 9, 2024
clabby
reviewed
Oct 9, 2024
clabby
reviewed
Oct 9, 2024
cody-wang-cb
force-pushed
the
cody/eip1559-params
branch
from
fc826a5
to
8dc0b36
Compare
cody-wang-cb
commented
Oct 9, 2024
tynes
reviewed
Oct 10, 2024
|
The consensus rules look good to me |
clabby
approved these changes
Oct 11, 2024
mattsse
reviewed
Oct 17, 2024
There was a problem hiding this comment.
@cody-wang-cb any new spec changes we need to include here?
if not I'm getting this over the line tmrw
Rjected
reviewed
Oct 17, 2024
There was a problem hiding this comment.
@mattsse the spec will most likely use extraData now for the 1559 params: ethereum-optimism/specs#428 so it looks like this will need to change to not have it in the nonce field
|
with #11887 do we still need this? |
|
Nope i can close this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Holocene changes to add EIP1559 params to payload, and using the
noncefield in block header to store the value.Spec: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md