Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(witness): destroyed slots as proof targets #11596

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Oct 9, 2024

Description

If account storage was destroyed, we must gather all slots from the current state for proof and following witness generation.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Oct 9, 2024
@rkrasiuk rkrasiuk requested a review from mattsse October 9, 2024 08:58
@rkrasiuk rkrasiuk requested a review from Rjected as a code owner October 9, 2024 08:58
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @Rjected

@rkrasiuk rkrasiuk added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 40faed6 Oct 9, 2024
37 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/witness-destroyed-storage-proof-targets branch October 9, 2024 16:15
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants