introduce standalone estimate gas type #12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
mattsse,
Rjected and
emhane
as code owners
mattsse
requested changes
Nov 6, 2024
| /// Gas estimator implementation | ||
| #[derive(Debug)] | ||
| pub struct GasEstimator<T> { | ||
| inner: Arc<T>, |
There was a problem hiding this comment.
we can remove the arc here
Comment on lines
34
to
39
| pub async fn estimate_gas_at( | ||
| &self, | ||
| request: TransactionRequest, | ||
| at: BlockId, | ||
| state_override: Option<StateOverride>, | ||
| ) -> impl Future<Output = Result<U256, T::Error>> + Send { |
There was a problem hiding this comment.
we def want this as a new trait trait GasEstimator
Comment on lines
48
to
50
| this.estimate_gas_with(cfg, block_env, request, state, state_override) | ||
| }) | ||
| .await |
There was a problem hiding this comment.
all this does here is reuse the existing estimate trait.
what we want instead is to extract this into a standalone type
Rjected
added
C-enhancement
mattsse
requested changes
Nov 12, 2024
There was a problem hiding this comment.
this must be updated so that the estimate functions are removed here
mattsse
approved these changes
Nov 14, 2024
|
cc @tcoratger this decouples estimation but could likely need more work |
@mattsse @stevencartavia thanks guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12250