Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PrimitiveSignature to test-vectors compact tests #12366

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/cli/commands/src/test_vectors/compact.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use alloy_primitives::{hex, private::getrandom::getrandom, TxKind};
use alloy_primitives::{hex, private::getrandom::getrandom, PrimitiveSignature, TxKind};
use arbitrary::Arbitrary;
use eyre::{Context, Result};
use proptest::{
Expand Down Expand Up @@ -126,7 +126,7 @@ compact_types!(
],
// These types require an extra identifier which is usually stored elsewhere (eg. parent type).
identifier: [
// Signature todo we for v we only store parity(true || false), while v can take more values
PrimitiveSignature,
Transaction,
TxType,
TxKind
Expand Down
Loading