feat: NetworkPrimitives
#12435
Merged
feat: NetworkPrimitives
#12435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/network-generics
branch
from
f74161b
to
565d52d
Compare
emhane
reviewed
Nov 10, 2024
Comment on lines
+77
to
+83
| impl NetworkPrimitives for EthNetworkPrimitives { | ||
| type BlockHeader = reth_primitives::Header; | ||
| type BlockBody = reth_primitives::BlockBody; | ||
| type Block = reth_primitives::Block; | ||
| type BroadcastedTransaction = reth_primitives::TransactionSigned; | ||
| type PooledTransaction = reth_primitives::PooledTransactionsElement; | ||
| } |
There was a problem hiding this comment.
this is basically double up of NodePrimitives, why the redundancy?
There was a problem hiding this comment.
I think we can always make NodePrimitives a supertrait if those actually end up same
the initial motivation was that transaction type is different so it would have to be a separate trait
There was a problem hiding this comment.
it is very similar and we could perhaps try to unify them but I feel like we should keep them separate for now because that makes it easier to transition the network component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
NetworkPrimitivestrait defining primitive types forethnetwork messages. For now just adds generics to reth-eth-wire-types, introducing those reth-network would be a more massive change