Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): make BlockBatchRecord generic over receipt #12449

Merged
merged 12 commits into from
Nov 14, 2024
Merged

chore(sdk): make BlockBatchRecord generic over receipt #12449

merged 12 commits into from
Nov 14, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 11, 2024

Based on #12448

Ref #12358

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 11, 2024
@emhane emhane mentioned this pull request Nov 11, 2024
Closed
@emhane emhane added the A-execution Related to the Execution and EVM label Nov 11, 2024
Base automatically changed from emhane/execution-outcome-generic to main November 12, 2024 10:55
mattsse
mattsse approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type, or rather how pruning works is a bit horrible, but this works

lgtm

@emhane emhane added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit b1635fc Nov 14, 2024
42 checks passed
@emhane emhane deleted the emhane/batch-generic-receipt branch November 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected

@fgimenez fgimenez Awaiting requested review from fgimenez

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse