Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix WASM build for crates dependent on reth-payload-primitives #12610

Merged
merged 1 commit into from
Nov 17, 2024
Merged

feat: fix WASM build for crates dependent on reth-payload-primitives #12610

merged 1 commit into from
Nov 17, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Nov 16, 2024 •
edited
Loading

Followup of #12600

  • Move PayloadBuilderError to reth-payload-primitives and reexport from reth-payload-builder-primitives
  • Remove dep of PayloadBuilderError on reth-transaction-pool by using Other variant for BlobStoreError
  • Leave only wasm-compatible features in tokio dep of reth-chain-state (rt-multi-thread is not used in the crate)

With this, these crates build for wasm32-wasip1 target:

  • reth-chain-state
  • reth-engine-primitives
  • reth-ethereum-engine-primitives
  • reth-node-types
  • reth-payload-builder
  • reth-payload-builder-primitives
  • reth-payload-primitives

mattsse
mattsse approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit 2f3fde8 Nov 17, 2024
44 checks passed
@mattsse mattsse deleted the fgimenez/fix-wasm-build branch November 17, 2024 10:49
@fgimenez fgimenez mentioned this pull request Nov 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgimenez @mattsse @DaniPopes