Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional op checks for chain specific check #12623

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 18, 2024

ref #12621

closes #12620

also, enforces that the chainspec is optimism and non dev, this should fix hive tests that use op mainnet chainid but with ethereum chainspec

@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Nov 18, 2024
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! should close #12620 ?

@mattsse
Copy link
Collaborator Author

mattsse commented Nov 18, 2024

yeah I think this should bypass it

@mattsse mattsse added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 1acdf9b Nov 18, 2024
41 checks passed
@mattsse mattsse deleted the matt/add-is-optimism-check branch November 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hive suite smoke/genesis failure
2 participants