Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor MockTransaction #12627

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: refactor MockTransaction #12627

merged 1 commit into from
Nov 18, 2024

Conversation

hai-rise
Copy link
Contributor

@hai-rise hai-rise commented Nov 18, 2024 •
edited
Loading

Random refactoring before a related PoolTransaction optimization.

@onbjerg onbjerg added the C-debt Refactor of code section that is hard to understand or maintain label Nov 18, 2024
mattsse
mattsse approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@onbjerg onbjerg added this pull request to the merge queue Nov 18, 2024
Merged via the queue into paradigmxyz:main with commit 626224e Nov 18, 2024
41 checks passed
@hai-rise hai-rise deleted the refactor-mock-tx branch November 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hai-rise @onbjerg @mattsse