feat: NodePrimitivesProvider
#12855
Merged
feat: NodePrimitivesProvider
#12855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/primitives-provider
branch
from
343709d to
78b600f
Compare
mattsse
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
NodePrimitivesProviderwhich serves as a common supertrait for traits which outputs are generic overN: NodePrimtiives. Those include (and likely not limited to)StaticFileProviderFactory,CanonStateSubscriptionsandBlockExecutionWriter.Because
BlockchainTreedepends onChaintype which is now generic overNodePrimitives, we'd need to either introduceNodePrimitivesgenerics for all legacy engine types to allow them to be used with both op and eth primitives, or maintain a thirdNodePrimitivesimpl exclusively for legacy engine.For now we're anyway using
EthPrimtiivesanywhere, so I've added bounds restricting primitives to it but once we start replacing primitives with chain-specific types this would need to be addressed.