Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use pooled AT for get_pooled_transactions #12876

Merged
merged 2 commits into from
Nov 26, 2024
Merged

feat: use pooled AT for get_pooled_transactions #12876

merged 2 commits into from
Nov 26, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 26, 2024

removes hardcoded PooledTransactionElement from pool trait and replace with AT Pooled type

adds a helpter that applies an Into because the network operates on the unrecovered variant.

this should unblock more generalization on TransactionManager

@mattsse mattsse added A-tx-pool Related to the transaction mempool A-sdk Related to reth's use as a library labels Nov 26, 2024
@mattsse mattsse requested a review from klkvr November 26, 2024 12:43
@mattsse mattsse added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 2776310 Nov 26, 2024
40 checks passed
@mattsse mattsse deleted the matt/make-use-pooled-type-for-get-elements branch November 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @klkvr