Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Receipt AT to writer traits #12892

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 27, 2024

Based on #12890, #12887

Adds Receipt AT to writer traits which operate on ExecutionOutcome

I've merged StateChangeWriter trait into StateWriter trait to avoid having separate generics on those. They were separated before because StateWriter was implemented separately on UnifiedStorageWriter which was changed in #12878

With this PR providers now do not depend on concrete primitive types besides Header which we've agreed to abstract a bit later

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klkvr klkvr force-pushed the klkvr/provider-receipt-generic branch from 766e72f to 172c02a Compare November 27, 2024 13:42
@klkvr klkvr requested a review from gakonst as a code owner November 27, 2024 13:42
Base automatically changed from klkvr/provider-receipt-generic to main November 27, 2024 14:18
@klkvr klkvr force-pushed the klkvr/writer-receipt-generic branch from ac3a467 to a11b936 Compare November 27, 2024 15:16
@klkvr klkvr enabled auto-merge November 27, 2024 15:16
@klkvr klkvr added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 7a6a725 Nov 27, 2024
41 checks passed
@klkvr klkvr deleted the klkvr/writer-receipt-generic branch November 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants