Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(trie): avoid update reallocation & track wiped #12929

Merged
merged 2 commits into from
Nov 28, 2024
Merged

perf(trie): avoid update reallocation & track wiped #12929

merged 2 commits into from
Nov 28, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Use std collections for SparseTrieUpdates to avoid reallocations.

Nit: track wiped flag inside SparseTrieUpdates.

@rkrasiuk rkrasiuk added C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Nov 27, 2024
@rkrasiuk rkrasiuk marked this pull request as draft November 27, 2024 22:43
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/perf-sparse-trie-updates branch from c772fe2 to aa26111 Compare November 28, 2024 12:56
@rkrasiuk rkrasiuk marked this pull request as ready for review November 28, 2024 12:56
@rkrasiuk rkrasiuk changed the title perf(trie): use std for sparse trie updates & track wiped perf(trie): avoid update reallocation & track wiped Nov 28, 2024
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/perf-sparse-trie-updates branch from aa26111 to c66daba Compare November 28, 2024 13:01
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 8c86d63 Nov 28, 2024
40 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/perf-sparse-trie-updates branch November 28, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @shekhirin