Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use alloy hash map in trie related code #12956

Merged
merged 1 commit into from
Nov 28, 2024
Merged

perf: use alloy hash map in trie related code #12956

merged 1 commit into from
Nov 28, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Use alloy hash map in all trie related code. This allows eliminating unnecessary conversions like below

reth/crates/trie/sparse/src/state.rs

Lines 263 to 267 in cb31d34

let updates = StorageTrieUpdates {
is_deleted: self.wiped_storages.contains(address),
storage_nodes: HashMap::from_iter(updates.updated_nodes),
removed_nodes: HashSet::from_iter(updates.removed_nodes),
};

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain C-perf A change motivated by improving speed, memory usage or disk footprint labels Nov 28, 2024
mattsse
mattsse approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk enabled auto-merge November 28, 2024 12:01
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit c274462 Nov 28, 2024
41 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/alloy-hash-map branch November 28, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @shekhirin @mattsse