Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): use SparseStateTrie::update_account in state root task #12960

Merged
merged 4 commits into from
Nov 28, 2024
Merged

feat(engine): use SparseStateTrie::update_account in state root task #12960

merged 4 commits into from
Nov 28, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Nov 28, 2024 •
edited
Loading

Integrates #12954

@shekhirin shekhirin added C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation labels Nov 28, 2024
@shekhirin shekhirin marked this pull request as ready for review November 28, 2024 12:52
rkrasiuk
rkrasiuk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

crates/engine/tree/src/tree/root.rs Show resolved Hide resolved
@shekhirin shekhirin enabled auto-merge November 28, 2024 13:01
@shekhirin shekhirin disabled auto-merge November 28, 2024 13:04
@shekhirin shekhirin enabled auto-merge November 28, 2024 13:05
@shekhirin shekhirin added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@shekhirin shekhirin enabled auto-merge November 28, 2024 13:32
@shekhirin shekhirin added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 8589503 Nov 28, 2024
40 checks passed
@shekhirin shekhirin deleted the alexey/state-root-task-update-account branch November 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk