Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(tree): keep storage trie around for updates #12971

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Keep reference to storage trie around for all updates. This prevents redundant storage trie fetches from the hashmap.

@rkrasiuk rkrasiuk added C-perf A change motivated by improving speed, memory usage or disk footprint A-engine Related to the engine implementation A-trie Related to Merkle Patricia Trie implementation labels Nov 28, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit regarding naming

@rkrasiuk rkrasiuk enabled auto-merge November 28, 2024 15:40
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit e1b25c8 Nov 28, 2024
40 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/tree-storage-trie-mut-ref branch November 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Related to the engine implementation A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants