Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): fetched proof targets in state root task #12983

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix(engine): fetched proof targets in state root task #12983

merged 2 commits into from
Nov 28, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Nov 28, 2024 •
edited
Loading

We should cache the fetched proofs by hashed addresses and hashed slots separately, because hashed slots can have duplicates.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Nov 28, 2024
@shekhirin shekhirin marked this pull request as ready for review November 28, 2024 17:44
fgimenez
fgimenez approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. would be nice to have unit tests for get_proof_targets, i can work on them in a follow up

@shekhirin shekhirin added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit ae395e8 Nov 28, 2024
40 checks passed
@shekhirin shekhirin deleted the alexey/state-root-task-fetched-proofs branch November 28, 2024 18:40
@fgimenez fgimenez mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@fgimenez fgimenez fgimenez approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @fgimenez @rkrasiuk