refactor: pending block construction #13109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Dec 3, 2024
Comment on lines
+107
to
+113
| .next_cfg_and_block_env( | ||
| &latest, | ||
| NextBlockEnvAttributes { | ||
| timestamp: latest.timestamp() + 12, | ||
| suggested_fee_recipient: latest.beneficiary(), | ||
| prev_randao: B256::random(), | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the logic assumes that we might have an actual pending block but not its receipts which is not possible.
This PR changes it so that we only fallback to manual block building when we are deriving it from the latest header.
Additionally, this delegates the pending block env construction to
next_cfg_and_block_envto avoid manually changing header fields as it's not possible for generic headers.This should now make it easier to delegate all of this to payload builder, as we no longer have to build a block given a header from CL