feat(builder): ethereum builder config #13315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-enhancement
mattsse
approved these changes
Dec 11, 2024
crates/ethereum/node/src/node.rs
Outdated
| pub struct EthereumPayloadBuilder; | ||
| pub struct EthereumPayloadBuilder { | ||
| /// Payload builder configuration. | ||
| builder_config: EthereumBuilderConfig, |
There was a problem hiding this comment.
Suggested change
| builder_config: EthereumBuilderConfig, | |
| config: EthereumBuilderConfig, |
crates/ethereum/node/src/node.rs
Outdated
| @@ -228,9 +230,29 @@ where | |||
| } | |||
|
|
|||
| /// A basic ethereum payload service. | |||
| #[derive(Debug, Default, Clone)] | |||
| #[derive(Clone, Debug)] | |||
| #[non_exhaustive] | |||
There was a problem hiding this comment.
Suggested change
| #[non_exhaustive] |
| @@ -247,6 +247,7 @@ impl<C: ChainSpecParser<ChainSpec = ChainSpec>> Command<C> { | |||
|
|
|||
| let payload_builder = reth_ethereum_payload_builder::EthereumPayloadBuilder::new( | |||
| EthEvmConfig::new(provider_factory.chain_spec()), | |||
| EthereumBuilderConfig::new(Default::default()), | |||
There was a problem hiding this comment.
perhaps it would be better if EthereumBuilderConfig had Default?
There was a problem hiding this comment.
ideally, this would be default_extradata(), but it's not available in the crate where EthereumBuilderConfig is defined, so i'd rather not have the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ethereum builder config, towards #13128