feat: introduce OpNetworkPrimitives #13335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
force-pushed
the
dan/op-network-primitives
branch
from
79261b4 to
a1560e0
Compare
Rjected
force-pushed
the
dan/op-network-primitives
branch
from
a1560e0 to
6de498d
Compare
Rjected
requested review from
mattsse,
fgimenez,
emhane,
onbjerg and
klkvr
as code owners
Rjected
added
C-enhancement
mattsse
approved these changes
Dec 14, 2024
crates/cli/commands/src/stage/mod.rs
Outdated
Comment on lines
51
to
56
| P: NetworkPrimitives< | ||
| BlockHeader = HeaderTy<N>, | ||
| BlockBody = BodyTy<N>, | ||
| Block = BlockTy<N>, | ||
| Receipt = ReceiptTy<N>, | ||
| >, |
There was a problem hiding this comment.
can we add an alias for this?
There was a problem hiding this comment.
yeah we'll need it in a few places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at creating
OpNetworkPrimitives, which is identical toEthNetworkPrimitivesfor now