perf(root): prefetch account proofs for the block #13431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-perf
shekhirin
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
shekhirin
force-pushed
the
alexey/state-root-task-prefetch
branch
from
39cc718 to
e9254b6
Compare
rkrasiuk
requested changes
Dec 18, 2024
crates/engine/tree/src/tree/mod.rs
Outdated
| @@ -2255,6 +2255,7 @@ where | |||
| // | |||
| // let state_root_task = StateRootTask::new(state_root_config, | |||
| // blinded_provider_factory); let state_hook = state_root_task.state_hook(); | |||
| // state_root_task.prefetch_account_proofs(&sealed_block.body); | |||
There was a problem hiding this comment.
Suggested change
| // state_root_task.prefetch_account_proofs(&sealed_block.body); | |
| // state_root_task.prefetch_account_proofs(sealed_block.transactions_with_sender()); |
rkrasiuk
reviewed
Dec 18, 2024
crates/engine/tree/src/tree/root.rs
Outdated
| accounts.extend( | ||
| body.transactions() | ||
| .iter() | ||
| .flat_map(|tx| [tx.recover_signer(), tx.kind().to().copied()]) |
shekhirin
force-pushed
the
alexey/state-root-task-prefetch
branch
from
1d9befb to
3906e82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reth/crates/engine/tree/src/tree/root.rs
Lines 346 to 351 in 0596fdb