Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Allow custom dev genesis file #13862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): Allow custom dev genesis file #13862

wants to merge 1 commit into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 18, 2025

Closes #13596

Struggling to write a unit test for this, relative path to test json file isn't read in NodeCommand::parse_from. Any hints?

@emhane emhane added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Jan 18, 2025
mattsse
mattsse reviewed Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, custom chainspec and --dev are currently mutually exclusive

this fix looks correct, but will confirm first

@emhane emhane enabled auto-merge January 20, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom gas limit with -dev flag
2 participants
@emhane @mattsse