chore: add eth68 to default capabilities #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/add-eth68-to-caps
branch
from
abbeaaa to
6c64113
Compare
rkrasiuk
reviewed
Feb 21, 2023
Comment on lines
+102
to
+104
| capabilities: capabilities.unwrap_or_else(|| { | ||
| vec![EthVersion::Eth68.into(), EthVersion::Eth67.into(), EthVersion::Eth66.into()] | ||
| }), |
There was a problem hiding this comment.
what has changed since this comment?
There was a problem hiding this comment.
The devp2p hive tests expect eth/68 in the Status, which at the time I'm not sure we knew due to other errors in the hive tests. So we need to advertise 68 now in the hello, and send an eth/68 status
Rjected
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable 68 as the default caps
Blocked by #1478