feat: add eth-wire #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Oct 8, 2022
|
|
||
| #[test] | ||
| fn encode_eth_status_message() { | ||
| let expected = hex!("f85643018a07aac59dabcdd74bc567a0feb27336ca7923f8fab3bd617fcb6e75841538f71c1bcfc267d7838489d9e13da0d4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3c684b715077d80"); |
There was a problem hiding this comment.
I'm not sure where this specific test vector is from, the exact difficulty doesn't seem to be in any block and I'm not sure where the hash came from (no uncles at that total difficulty's height either).
I had listened for incoming status messages on mainnet to get test vectors originally, this may be left over from that process.
|
LMK if still WIP or if you'd like a review |
|
@gakonst feel free to review, not WIP |
mattsse
reviewed
Oct 10, 2022
crates/net/eth-wire/src/status.rs
Outdated
| use ethereum_forkid::ForkId; | ||
| use fastrlp::{RlpDecodable, RlpEncodable}; | ||
| use reth_primitives::Chain; | ||
| use ruint::Uint; |
There was a problem hiding this comment.
is there a particular benefit for ruint here?
I'd suggest using the U256 from primitives
There was a problem hiding this comment.
no real benefit, using U256 makes sense and should work
There was a problem hiding this comment.
let's import from primitives then, this way we can easily replace the type if we end up doing this.
crates/net/eth-wire/src/status.rs
Outdated
| pub total_difficulty: Uint<256, 4>, | ||
|
|
||
| /// The highest difficulty block hash the peer has seen | ||
| pub blockhash: [u8; 32], |
crates/net/eth-wire/src/status.rs
Outdated
| pub blockhash: [u8; 32], | ||
|
|
||
| /// The genesis hash of the peer's chain. | ||
| pub genesis: [u8; 32], |
* should unpin forkid and upgrade all once ethereum-types is bumped everywhere * forkid and fastrlp have no git history between versions, but forkid 0.10 uses primitive-types 0.11 which is the same as current ethers
anonymousGiga
added a commit
to anonymousGiga/reth
that referenced
this pull request
Feb 20, 2024
* adust th display order of fields * refactor: Involving gas record and time record * perf: update perf test code of cachedb refactor: refactor something --------- Co-authored-by: xudaquan2003 <xudaquan2003@gmail.com>
yutianwu
pushed a commit
to yutianwu/reth
that referenced
this pull request
Jul 1, 2024
AshinGau
pushed a commit
to AshinGau/reth
that referenced
this pull request
Oct 13, 2024
…ransactions (paradigmxyz#20) Before Opt. ``` Independent Raw Transfers/Grevm Parallel time: [117.65 ms 118.22 ms 118.61 ms] ``` After Opt. ``` Independent Raw Transfers/Grevm Parallel time: [102.60 ms 103.34 ms 104.18 ms] change: [-13.185% -12.440% -11.552%] (p = 0.00 < 0.05) ```
AshinGau
pushed a commit
to AshinGau/reth
that referenced
this pull request
Oct 13, 2024
…ransactions (paradigmxyz#20) Before Opt. ``` Independent Raw Transfers/Grevm Parallel time: [117.65 ms 118.22 ms 118.61 ms] ``` After Opt. ``` Independent Raw Transfers/Grevm Parallel time: [102.60 ms 103.34 ms 104.18 ms] change: [-13.185% -12.440% -11.552%] (p = 0.00 < 0.05) ```
Brechtpd
pushed a commit
to taikoxyz/gwyneth
that referenced
this pull request
Oct 17, 2024
…aiko_mono feat(gwyneth): update everything (except core protocol) to latest taiko-mono
greged93
pushed a commit
to greged93/reth
that referenced
this pull request
Nov 8, 2024
…am-161605313 chore: merge upstream 1616053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some code from ethp2p, just
StatusandEthVersionfor now. For the rest of the wire protocol, most types inprimitivesneed to be complete and they need to implementfastrlp::{Encodable, Decodable}. TheStatusis specifically important for the initialethhandshake implementation.