Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): impl traceCall #2029

Merged
merged 2 commits into from
Mar 31, 2023
Merged

feat(rpc): impl traceCall #2029

merged 2 commits into from
Mar 31, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 29, 2023

Closes #2011

adds helper functions to EthTransaction trait to transact inspect.

This gets rid of the MaybeStackedInspector<GasInpsector> in the trace inspector, to safely make it Send.
even if executed as part of a Stack the overhead is negligible and for tracing rpc impl we never run a stack.

@mattsse mattsse added the A-rpc Related to the RPC implementation label Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #2029 (858049b) into main (cda6647) will decrease coverage by 0.01%.
The diff coverage is 36.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2029      +/-   ##
==========================================
- Coverage   72.80%   72.79%   -0.01%     
==========================================
  Files         428      428              
  Lines       52506    52535      +29     
==========================================
+ Hits        38225    38243      +18     
- Misses      14281    14292      +11     
Flag Coverage Δ
integration-tests 19.46% <36.92%> (+0.03%) ⬆️
unit-tests 66.98% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/call.rs 57.76% <ø> (-2.06%) ⬇️
crates/rpc/rpc/src/trace.rs 35.50% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/transactions.rs 27.41% <66.66%> (+4.95%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gakonst gakonst merged commit 00712d6 into main Mar 31, 2023
@gakonst gakonst deleted the matt/impl-eth-trace-call branch March 31, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement trace_call
3 participants