Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update defaults in builder #3299

Merged
merged 3 commits into from
Jun 21, 2023
Merged

chore: update defaults in builder #3299

merged 3 commits into from
Jun 21, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 21, 2023

ref #3290

@mattsse mattsse mentioned this pull request Jun 21, 2023
Closed
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #3299 (8a30bbc) into main (6c17193) will decrease coverage by 0.05%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #3299      +/-   ##
==========================================
- Coverage   69.76%   69.71%   -0.05%     
==========================================
  Files         530      530              
  Lines       71537    71536       -1     
==========================================
- Hits        49906    49873      -33     
- Misses      21631    21663      +32
Flag Coverage Δ
integration-tests 16.37% <40.00%> (-0.02%) ⬇️
unit-tests 64.76% <30.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-builder/src/auth.rs 42.63% <0.00%> (-0.53%) ⬇️
bin/reth/src/args/rpc_server_args.rs 47.35% <60.00%> (ø)
crates/rpc/rpc-builder/src/lib.rs 68.44% <100.00%> (-0.04%) ⬇️

... and 7 files with indirect coverage changes

@mattsse mattsse enabled auto-merge June 21, 2023 13:06
@mattsse mattsse added this pull request to the merge queue Jun 21, 2023
Merged via the queue into main with commit 0c222e5 Jun 21, 2023
@mattsse mattsse deleted the matt/rya0x-localhost branch June 21, 2023 13:51
@onbjerg onbjerg added C-enhancement New feature or request A-block-building Related to block building labels Jun 21, 2023
yuichiroaoki pushed a commit to yuichiroaoki/reth that referenced this pull request Jun 22, 2023
@mattsse @0xlosh @yuichiroaoki
chore: update defaults in builder (paradigmxyz#3299)
10bc181 
Co-authored-by: 0xlosha <koppel444@gmx.de>
Co-authored-by: rya <83345377+rya0x@users.noreply.github.com>
@onbjerg onbjerg added the M-changelog This change should be included in the changelog label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattsse @rkrasiuk @onbjerg @0xlosh